Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling for experimental features #1915

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Mar 9, 2023

  • fix mistagged features to be treated as experimental:
    • everything tied to publishing
    • the export sub-command
    • misc others
  • fix experimental sub-commands to only be available in power mode

@Gedochao Gedochao added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Mar 9, 2023
@Gedochao Gedochao force-pushed the specification-level-experimental branch from f74cf37 to 5bc1d33 Compare March 9, 2023 11:11
@Gedochao Gedochao requested review from lwronski and MaciejG604 March 9, 2023 11:17
@Gedochao Gedochao marked this pull request as ready for review March 9, 2023 11:17
@Gedochao Gedochao force-pushed the specification-level-experimental branch 2 times, most recently from ecae84f to a226c2a Compare March 10, 2023 08:38
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao enabled auto-merge March 10, 2023 09:51
- hide `experimental` sub-commands behind `--power` mode
- tag `export` and everything tied to publishing as experimental
- add tests
… options without the `power` mode enabled
… directives without the `power` mode enabled; tag publishing directives as `experimental`
- fix confusing 'restricted mode' naming in favor of `power mode`
- misc fixes
@Gedochao Gedochao force-pushed the specification-level-experimental branch from a226c2a to 5c44437 Compare March 10, 2023 10:06
@Gedochao Gedochao merged commit e1d3042 into VirtusLab:main Mar 10, 2023
@Gedochao Gedochao deleted the specification-level-experimental branch March 10, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants