Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use locally build jvm launcher of scala-cli in gifs generator #1921

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Use locally build jvm launcher of scala-cli in gifs generator #1921

merged 3 commits into from
Mar 17, 2023

Conversation

lwronski
Copy link
Contributor

No description provided.

@lwronski lwronski linked an issue Mar 13, 2023 that may be closed by this pull request
Gifs are generated using scala-cli 0.1.15. #1919
Closed
@lwronski lwronski force-pushed the gifs-update-scala-cli branch 2 times, most recently from abe0218 to 9144712 Compare March 15, 2023 08:26
@lwronski lwronski marked this pull request as ready for review March 15, 2023 08:29
@lwronski lwronski requested review from Gedochao and MaciejG604 March 15, 2023 08:30
Gedochao
Gedochao approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwronski lwronski force-pushed the gifs-update-scala-cli branch from 9144712 to d1200f4 Compare March 17, 2023 08:02
@lwronski lwronski changed the base branch from main to stable March 17, 2023 08:02
@lwronski lwronski merged commit e80bcc8 into VirtusLab:stable Mar 17, 2023
@lwronski lwronski mentioned this pull request Mar 17, 2023
Closed
@Gedochao Gedochao added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@MaciejG604 MaciejG604 Awaiting requested review from MaciejG604

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gifs are generated using scala-cli 0.1.15.
2 participants
@lwronski @Gedochao