Write PGP keys to publish-conf when doing publish setup #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
reviewed
Mar 21, 2023
modules/cli/src/main/scala/scala/cli/commands/publish/PublishSetup.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/PublishSetupTests.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/PublishSetupTests.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/PublishSetupTests.scala
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/PublishSetupTests.scala
Outdated
Show resolved
Hide resolved
MaciejG604
force-pushed
the
pgp-checking-publish-setup
branch
2 times, most recently
from
c08a49f to
542cc7b
Compare
lwronski
approved these changes
Mar 27, 2023
modules/cli/src/main/scala/scala/cli/commands/publish/checks/PgpSecretKeyCheck.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/publish/checks/PgpSecretKeyCheck.scala
Outdated
Show resolved
Hide resolved
…ublic key to servers
MaciejG604
force-pushed
the
pgp-checking-publish-setup
branch
from
f11dec8 to
a4506d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
publish setupwrite down PGP keys to publish-confAlways check if keys are uploaded to a keyserver