Make object wrapper extend App #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejG604
force-pushed
the
make-object-wrapper-extend-app
branch
from
bd45387 to
1c63f76
Compare
MaciejG604
force-pushed
the
make-object-wrapper-extend-app
branch
from
1c63f76 to
117d695
Compare
…s to be called with backticked name
…ped with App can't call scripts from 'main.sc' files
MaciejG604
force-pushed
the
make-object-wrapper-extend-app
branch
2 times, most recently
from
a871cc7 to
7c175d7
Compare
MaciejG604
force-pushed
the
make-object-wrapper-extend-app
branch
2 times, most recently
from
97a4e2a to
bf86276
Compare
MaciejG604
force-pushed
the
make-object-wrapper-extend-app
branch
from
bf86276 to
966431f
Compare
Gedochao
approved these changes
Nov 20, 2023
modules/build/src/main/scala/scala/build/preprocessing/ScriptPreprocessor.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr Chabelski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2470
Thanks to @rochala for suggesting the solution of using a wrapper that extends App.
This simple fix seems to have been overlooked in the past, probably because it has some quirks when it comes to different Scala versions.
For Scala 2.12 and 2.13 an object that extends App avoids the deadlock when background threads are started from its initialization clause.
However, this is not true for Scala 3, it is a known bug that has not been fixed yet - scala/scala3#16149
RESTRICTIONS of the new wrapper:
main.sccan't be accessed from other scripts that use the App wrapper since the namemainclashes with theirmainmethod.