Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak benchmarking with JMH #3091

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Aug 12, 2024

  • updates jmh to 1.37 (was 1.29)
  • fixes IDE import for benchmarking projects (BSP reload is still broken, but the initial setup works)
  • lifts --jmh and --jmh-version to SharedOptions, making it available for more sub-commands (used to be just run)
    • compile will let benchmarking projects compile
    • package will now also work with --jmh, but it will mostly ignore it past compilation (the resulting artifact won't be running benchmarks, which is something to be fixed separately)
    • doc should work with benchmarking projects
    • bsp and setup-ide work correctly, but bsp fails to reload with --jmh (better than it was, but still needs fixing)
    • export will include the jmh-core dependency as compile-only and not fail, which is better than outright failing, but still needs improvements

@Gedochao Gedochao added the jmh Issues tied with JMH benchmarking. label Aug 12, 2024
@Gedochao Gedochao requested review from tgodzik and kasiaMarek August 12, 2024 12:30
@Gedochao Gedochao marked this pull request as draft August 12, 2024 13:39
@Gedochao Gedochao changed the title Bump jmh to 1.37 [WIP] Tweak benchmarking with JMH Aug 13, 2024
@Gedochao Gedochao requested a review from tgodzik August 13, 2024 13:56
@Gedochao Gedochao changed the title [WIP] Tweak benchmarking with JMH Tweak benchmarking with JMH Aug 13, 2024
@Gedochao Gedochao marked this pull request as ready for review August 14, 2024 07:18
@Gedochao Gedochao merged commit 49a0b02 into VirtusLab:main Aug 14, 2024
78 checks passed
@Gedochao Gedochao deleted the maintenance/jmh branch August 14, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jmh Issues tied with JMH benchmarking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants