Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make publishing depend on all integration tests & docs tests #3272

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Nov 12, 2024

@Gedochao Gedochao requested a review from tgodzik November 12, 2024 11:26
@Gedochao Gedochao mentioned this pull request Nov 12, 2024
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it might get hard to release because of flaky tests 🤔

@Gedochao
Copy link
Contributor Author

I'm predicting nightlies will become troublesome with this.
MIght need to expediate the audit of our integration tests after we release 1.5.3...

@Gedochao Gedochao enabled auto-merge November 12, 2024 11:41
@Gedochao Gedochao disabled auto-merge November 12, 2024 12:10
@Gedochao Gedochao force-pushed the maintenance/make-publish-depend-on-all-integration-tests branch from 32463aa to e3454f9 Compare November 12, 2024 15:17
@Gedochao Gedochao mentioned this pull request Nov 12, 2024
2 tasks
@Gedochao Gedochao merged commit 333cef0 into VirtusLab:main Nov 13, 2024
78 checks passed
@Gedochao Gedochao deleted the maintenance/make-publish-depend-on-all-integration-tests branch November 13, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants