Merge pull request #1667 from VisActor/fix/duplicated-label-id

Fix: duplicated label
VisActor · Jan 10, 2025 · 9562c1d · 9562c1d
2 parents 672210a + 67f3537
commit 9562c1d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/common/changes/@visactor/vrender-components/fix-duplicated-label-id_2025-01-07-06-46.json b/common/changes/@visactor/vrender-components/fix-duplicated-label-id_2025-01-07-06-46.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@visactor/vrender-components",
+      "comment": "fix: fix duplicate label issue after custom filtering with label dataFilter",
+      "type": "none"
+    }
+  ],
+  "packageName": "@visactor/vrender-components"
+}
diff --git a/packages/vrender-components/src/label/base.ts b/packages/vrender-components/src/label/base.ts
@@ -182,6 +182,12 @@ export class LabelBase<T extends BaseLabelAttrs> extends AbstractComponent<T> {
       data = dataFilter(data);
     }
 
+    if (data && data.length) {
+      // 数据保护，防止重复 id 造成不可预知的问题
+      const seenIds = new Set();
+      data = data.filter(d => !seenIds.has(d.id) && seenIds.add(d.id));
+    }
+
     let labels: (IText | IRichText)[] = this._initText(data);
 
     if (isFunction(customLayoutFunc)) {