Dockerfile/K8s implementation, prod/dev run #24
Conversation
There was a problem hiding this comment.
Hi @jorgejesus,
I left some comments on the PR.
I also wanted to check with you what's the plan with the AWS server. As you can see in .github/workflows/, this repository is still configured to automatically deploy to AWS when commits are pushed to develop and master. This would deploy the staging and production environments. Are those not needed anymore? Is TNC aware of it?
Finally, what will happen with #25? Should we close it?
.env.default
Outdated
| @@ -1,11 +1,11 @@ | |||
| PORT=3000 | |||
| NODE_PORT=3001 | |||
There was a problem hiding this comment.
Hey @jorgejesus,
This should be kept as PORT: PORT=3001. The Node.js app uses PORT here and your run.sh script also creates a variable called PORT here.
README.md
Outdated
| 3. Docker build will be initicated. | ||
| 4. After completed Docker image is stored on a private repository. | ||
| 5. Image will then be deplyed into the soils-revealed cluster. | ||
| 6. GKE contains a specific `ConfiMap` with all .env necessary for deployment. |
There was a problem hiding this comment.
I think ConfiMap should be ConfigMap.
|
Bouncing back on one of my previous comments, if we're to work on a new phase of this project, we'd like to keep having a staging environment on your new infrastructure and auto deployment with GitHub Actions, if possible. We don't need it at this point, but I'd like to make sure this will be possible in the future. Thanks! |
|
Thank you for your comments. I have made a new commit implementing When you merge into the vizzuality project. We need to have a fast zoom with you, so set up the repository to send the trigger to google cloud build. |
|
Thank you Jorge! |
* Dockerfile/K8s implementation, prod/dev run (#24) * Delete the GitHub Actions The app will now be built with ISRIC's Google Cloud account * google search verification file added (#31) * Modal to recruit user (airtable) (#30) * Modal to recruit user (airtable) * airtable: prevent giving a description if 'other' field is not selected * mobile fixes * updates in user recruitment modal * Updated env variable structure * cloudbuild configuration - automatic deployment Co-authored-by: Jorge S. Mendes de Jesus <[email protected]> * Typo on .dockerignore * Feat/modal check (#35) * Modal to recruit user (airtable) * airtable: prevent giving a description if 'other' field is not selected * updates in user recruitment modal * user modal local storage function Co-authored-by: Jorge Samuel Mendes de Jesus <[email protected]> Co-authored-by: Clément Prod'homme <[email protected]> Co-authored-by: Jorge S. Mendes de Jesus <[email protected]>
* Dockerfile/K8s implementation, prod/dev run (#24) * Modal to recruit user (airtable) (#30) * Modal to recruit user (airtable) * airtable: prevent giving a description if 'other' field is not selected * mobile fixes * updates in user recruitment modal * Updated env variable structure * cloudbuild configuration - automatic deployment Co-authored-by: Jorge S. Mendes de Jesus <[email protected]> * Feat/modal check (#35) * Modal to recruit user (airtable) * airtable: prevent giving a description if 'other' field is not selected * updates in user recruitment modal * user modal local storage function * airtable modal removed (#39) * | missing * Update docker to bullseye #45 Co-authored-by: Jorge Samuel Mendes de Jesus <[email protected]> Co-authored-by: Jorge S. Mendes de Jesus <[email protected]>
* Dockerfile/K8s implementation, prod/dev run (#24) * Modal to recruit user (airtable) (#30) * Modal to recruit user (airtable) * airtable: prevent giving a description if 'other' field is not selected * mobile fixes * updates in user recruitment modal * Updated env variable structure * cloudbuild configuration - automatic deployment Co-authored-by: Jorge S. Mendes de Jesus <[email protected]> * Feat/modal check (#35) * Modal to recruit user (airtable) * airtable: prevent giving a description if 'other' field is not selected * updates in user recruitment modal * user modal local storage function * airtable modal removed (#39) * | missing * Update docker to bullseye #45 * Modal Join us (#44) * Add 'Join us' modal * Add action button 'Join us' to top and bottom of Homepage * Add link 'Join us' in footer menu Co-authored-by: Jorge Samuel Mendes de Jesus <[email protected]> Co-authored-by: María Luena Rodríguez <[email protected]> Co-authored-by: Sidney Gijzen <[email protected]>
* Dockerfile/K8s implementation, prod/dev run (#24) * Modal to recruit user (airtable) (#30) * Modal to recruit user (airtable) * airtable: prevent giving a description if 'other' field is not selected * mobile fixes * updates in user recruitment modal * Updated env variable structure * cloudbuild configuration - automatic deployment Co-authored-by: Jorge S. Mendes de Jesus <[email protected]> * Feat/modal check (#35) * Modal to recruit user (airtable) * airtable: prevent giving a description if 'other' field is not selected * updates in user recruitment modal * user modal local storage function * airtable modal removed (#39) * | missing * Update docker to bullseye #45 * Modal Join us (#44) * Add 'Join us' modal * Add action button 'Join us' to top and bottom of Homepage * Add link 'Join us' in footer menu Co-authored-by: Jorge Samuel Mendes de Jesus <[email protected]> * add Inrae to About Us modal (#59) * Fix: new cluster name and env for cluster name * Fix: Possible fix for google clould build variable * Update: Rool back to fix k8s name The implementation of google env variable from cloud build is tricky, no time to look into it * Triggering a google build --------- Co-authored-by: María Luena Rodríguez <[email protected]> Co-authored-by: Sidney Gijzen <[email protected]>
yarn test --passWithNoTestsrun.shto kickstart a build process and then yarn startrun.shimplementsproduction/developDescription of the PR
Testing instructions
Run docker container
docker build -t soils-revealeddocker run -p3001:3001 --env-file .env soils-revealed:latest /soils-revealed/run.sh productionset
.envvariablesWhat to test? How to do it?
Pivotal Tracker
Link to the task(s), if any