Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move color ranges reducer upper to palette_configuration #3

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Move color ranges reducer upper to palette_configuration #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b378e1b
Move color ranges reducer upper to palette_configuration
VladLasitsa Jan 12, 2022
54516ad
Remove from local state unnecessary params
VladLasitsa Jan 13, 2022
a6b6dc4
Fix some cases
VladLasitsa Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 0 additions & 165 deletions ...s/public/shared_components/coloring/color_ranges/__snapshots__/color_ranges.test.tsx.snap
View file
Open in desktop

This file was deleted.

45 changes: 26 additions & 19 deletions x-pack/plugins/lens/public/shared_components/coloring/color_ranges/color_ranges.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,6 @@ import React from 'react';
import { act } from 'react-dom/test-utils';
import { ColorRanges, ColorRangesProps } from './color_ranges';
import { ReactWrapper } from 'enzyme';
import type { ColorRangesItemProps } from './color_ranges_item';

const colorRangeItemExtractProps = (component: ReactWrapper) => {
const props = component.props() as ColorRangesItemProps;

return {
index: props.index,
accessor: props.accessor,
isValid: props.isValid,
colorRange: props.colorRange,
};
};

const extraActionSelectors = {
addColorRange: '[data-test-subj^="lnsPalettePanel_dynamicColoring_addColorRange"]',
Expand All @@ -40,8 +28,10 @@ const pageObjects = {

describe('Color Ranges', () => {
let props: ColorRangesProps;
let dispatch = jest.fn();

beforeEach(() => {
dispatch.mockClear();
props = {
colorRanges: [
{ color: '#aaa', start: 20, end: 40 },
Expand All @@ -52,8 +42,9 @@ describe('Color Ranges', () => {
rangeType: 'number',
continuity: 'none',
},
showExtraActions: true,
dataBounds: { min: 0, max: 200 },
onChange: jest.fn(),
dispatch,
};
});

Expand Down Expand Up @@ -87,7 +78,10 @@ describe('Color Ranges', () => {

component.update();

expect(component.find('ColorRangeItem').map(colorRangeItemExtractProps)).toMatchSnapshot();
expect(dispatch).toHaveBeenCalledWith({
type: 'addColorRange',
payload: { dataBounds: { min: 0, max: 200 } },
});
});

it('should sort ranges value on whole component blur', () => {
Expand All @@ -98,13 +92,23 @@ describe('Color Ranges', () => {
firstInput.simulate('change', { target: { value: ' 65' } });
});

expect(dispatch).toHaveBeenNthCalledWith(1, {
type: 'updateValue',
payload: { index: 0, value: ' 65', accessor: 'start' },
});

props.colorRanges = [
{ color: '#aaa', start: 65, end: 40 },
{ color: '#bbb', start: 40, end: 60 },
{ color: '#ccc', start: 60, end: 80 },
];
component.setProps({ colorRanges: props.colorRanges });

act(() => {
firstInput.simulate('blur');
});

component.update();

expect(component.find('ColorRangeItem').map(colorRangeItemExtractProps)).toMatchSnapshot();
expect(dispatch).toHaveBeenNthCalledWith(2, { type: 'sortColorRanges' });
});

it('should reverse colors when user click "reverse"', () => {
Expand All @@ -122,7 +126,7 @@ describe('Color Ranges', () => {

component.update();

expect(component.find('EuiColorPicker').map((item) => item.prop('color'))).toMatchSnapshot();
expect(dispatch).toHaveBeenCalledWith({ type: 'reversePalette' });
});

it('should distribute equally ranges when use click on "Distribute equally" button', () => {
Expand All @@ -141,6 +145,9 @@ describe('Color Ranges', () => {

component.update();

expect(component.find('ColorRangeItem').map(colorRangeItemExtractProps)).toMatchSnapshot();
expect(dispatch).toHaveBeenCalledWith({
type: 'distributeEqually',
payload: { dataBounds: { min: 0, max: 200 } },
});
});
});
Loading