Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit tests #447

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Improve unit tests #447

merged 5 commits into from
Jul 12, 2024

Conversation

asimonok
Copy link
Collaborator

Resolves #414

@asimonok asimonok requested a review from mikhail-vl July 11, 2024 08:23
@asimonok asimonok self-assigned this Jul 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (710f6df) to head (765a0c0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files          76       76           
  Lines        1678     1678           
  Branches      452      452           
=======================================
  Hits         1661     1661           
  Misses         15       15           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 11, 2024
@mikhail-vl mikhail-vl added this to the Forms 4.2.0 milestone Jul 11, 2024
mikhail-vl
mikhail-vl approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit c1008f9 into main Jul 12, 2024
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/impove-unit-tests branch July 12, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@asimonok asimonok

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Forms 4.2.0
Development

Successfully merging this pull request may close these issues.

Improve Unit Tests
2 participants
@asimonok @mikhail-vl