Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the logic for comparing values with the initial values #454

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #444

@vitPinchuk vitPinchuk self-assigned this Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (710f6df) to head (7b533c1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files          76       76           
  Lines        1678     1679    +1     
  Branches      452      496   +44     
=======================================
+ Hits         1661     1662    +1     
  Misses         15       15           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 15, 2024
@mikhail-vl mikhail-vl added this to the Forms 4.2.0 milestone Jul 15, 2024
src/components/FormPanel/FormPanel.tsx Outdated Show resolved Hide resolved
@vitPinchuk vitPinchuk requested a review from asimonok July 15, 2024 10:57
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit a3d79cf into main Jul 16, 2024
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/clear-submit-upload-files branch July 16, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

File Form Element - Submit button remains enabled after uploaded file is deleted
3 participants