Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update position of Query fields for initial values #455

Merged
merged 10 commits into from
Jul 18, 2024

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Jul 16, 2024

Resolves: #443

@vitPinchuk vitPinchuk self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (a3d79cf) to head (416fdd3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   98.98%   98.99%           
=======================================
  Files          76       78    +2     
  Lines        1679     1690   +11     
  Branches      496      453   -43     
=======================================
+ Hits         1662     1673   +11     
  Misses         15       15           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk requested review from mikhail-vl and asimonok and removed request for mikhail-vl July 16, 2024 09:14
@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 16, 2024
@mikhail-vl mikhail-vl added this to the Forms 4.2.0 milestone Jul 16, 2024
@mikhail-vl mikhail-vl changed the title Relocate field for initial values Update position of field for initial values Jul 17, 2024
@mikhail-vl mikhail-vl changed the title Update position of field for initial values Update position of field for Query fields Jul 17, 2024
@mikhail-vl mikhail-vl changed the title Update position of field for Query fields Update position of Query fields for initial values Jul 17, 2024
@mikhail-vl
Copy link
Member

@vitPinchuk I did Initial Fields updates and broke tests.

Could you please fix for @asimonok review.

Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit d546ecf into main Jul 18, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/fields-relocation branch July 18, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Pre-Select Checkbox when i get data from Infinity datasource
3 participants