Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration helper if nested object properties are not defined #468

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

asimonok
Copy link
Collaborator

Resolves #466
Resolves #467

@asimonok asimonok added the bug Something isn't working label Aug 16, 2024
@asimonok asimonok requested a review from mikhail-vl August 16, 2024 11:35
@asimonok asimonok self-assigned this Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (4833196) to head (b0c62a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         119      119           
  Lines        1945     1949    +4     
  Branches      511      516    +5     
=======================================
+ Hits         1926     1930    +4     
  Misses         17       17           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl changed the title Fix migration helper if nested object properties are not defined Update migration helper if nested object properties are not defined Aug 16, 2024
@mikhail-vl mikhail-vl modified the milestones: Forms 4.4.0, Forms 4.3.0 Aug 16, 2024
@mikhail-vl mikhail-vl changed the title Update migration helper if nested object properties are not defined Fix migration helper if nested object properties are not defined Aug 16, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 3f8185a into main Aug 16, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/fix-migration-in-dashboard-scene branch August 16, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants