Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data source query display error #477

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Update data source query display error #477

merged 3 commits into from
Aug 29, 2024

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Aug 29, 2024 •
edited
Loading

Resolves: #475

@vitPinchuk vitPinchuk self-assigned this Aug 29, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (d7c5cf1) to head (c13d6aa).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         119      119           
  Lines        1951     1955    +4     
  Branches      472      521   +49     
=======================================
+ Hits         1932     1936    +4     
  Misses         17       17           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk requested a review from mikhail-vl August 29, 2024 08:18
@mikhail-vl mikhail-vl added the enhancement New feature or request label Aug 29, 2024
@mikhail-vl mikhail-vl added this to the Forms 4.4.0 milestone Aug 29, 2024
@vitPinchuk vitPinchuk marked this pull request as draft August 29, 2024 10:08
@vitPinchuk vitPinchuk marked this pull request as ready for review August 29, 2024 10:39
@vitPinchuk
Copy link
Contributor Author

@mikhail-vl Ready for review

@mikhail-vl mikhail-vl changed the title Update Datasource error display Update data source query display error Aug 29, 2024
mikhail-vl
mikhail-vl approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 20a8fdc into main Aug 29, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/update-error-showing branch August 29, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Forms 4.4.0
Development

Successfully merging this pull request may close these issues.

Multi-line issue with text areas
2 participants
@vitPinchuk @mikhail-vl