Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update suggestions position in Code elements #483

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Update suggestions position in Code elements #483

merged 5 commits into from
Sep 6, 2024

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Sep 4, 2024 •
edited by mikhail-vl
Loading

Resolves #481

@mikhail-vl mikhail-vl added this to the Forms 4.5.0 milestone Sep 4, 2024
@mikhail-vl mikhail-vl added the enhancement New feature or request label Sep 4, 2024
@asimonok asimonok marked this pull request as ready for review September 6, 2024 11:04
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.13%. Comparing base (ec48e47) to head (8e733ef).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files         119      119           
  Lines        1959     1961    +2     
  Branches      476      521   +45     
=======================================
+ Hits         1942     1944    +2     
  Misses         15       15           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asimonok asimonok changed the title Draft: Suggestions in Code elements Suggestions in Code elements Sep 6, 2024
@asimonok asimonok requested a review from mikhail-vl September 6, 2024 11:11
@mikhail-vl mikhail-vl changed the title Suggestions in Code elements Update suggestions position in Code elements Sep 6, 2024
mikhail-vl
mikhail-vl approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit e8ab6ee into main Sep 6, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/suggestion-in-code-eement branch September 6, 2024 11:21
@mikhail-vl mikhail-vl mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Forms 4.5.0
Development

Successfully merging this pull request may close these issues.

Suggestions in Code elements displayed below the panel
3 participants
@vitPinchuk @mikhail-vl @asimonok