Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support variables in data sources #564

Merged
merged 12 commits into from
Dec 20, 2024
Merged

Add support variables in data sources #564

merged 12 commits into from
Dec 20, 2024

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Nov 29, 2024 •
edited by asimonok
Loading

Resolves: #553

@vitPinchuk vitPinchuk self-assigned this Nov 29, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (4471ba8) to head (e928d95).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   99.09%   99.07%   -0.03%     
==========================================
  Files         119      116       -3     
  Lines        2102     2049      -53     
  Branches      536      533       -3     
==========================================
- Hits         2083     2030      -53     
  Misses         17       17              
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk marked this pull request as draft November 29, 2024 11:10
@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 29, 2024
@mikhail-vl mikhail-vl added this to the Forms 5.0.0 milestone Nov 29, 2024
asimonok
asimonok requested changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[email protected] is published
Please update PR

@vitPinchuk vitPinchuk requested a review from asimonok December 6, 2024 14:11
@vitPinchuk vitPinchuk marked this pull request as ready for review December 6, 2024 14:11
@mikhail-vl mikhail-vl changed the title Support variables in data sources Add support variables in data sources Dec 9, 2024
asimonok
asimonok approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit c509597 into main Dec 20, 2024
7 of 8 checks passed
@mikhail-vl mikhail-vl deleted the feat/support-vars-in-ds branch December 20, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Forms 5.0.0
Development

Successfully merging this pull request may close these issues.

Support variables in data sources for editable and nested objects
3 participants
@vitPinchuk @asimonok @mikhail-vl