append counterReset to docx-wrapper only when root element #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolodymyrBaydalka
force-pushed
the
master
branch
3 times, most recently
from
11eb7fa to
88d7d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when counter-reset is applied to the docx-wrapper class, it seems to result in nested numberings never being reset. By only appending resetCounters that are root level, it seems like these issues go away.
This is my first contribution, if you need me to update the unit tests, please give me a brief description how to replace the index.html documents effectively. This PR changes the output so that the unit test fails.
#136 Fixes this issue