chore(docs): Badge docs update (VIV-2083) #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2080 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 374 +251
Lines 1562 9362 +7800
Branches 108 1508 +1400
===========================================
+ Hits 1562 9362 +7800
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TaylorJ76
requested changes
Jan 20, 2025
| ></vwc-badge> | ||
| ``` | ||
|
|
||
| ### Icon Only |
There was a problem hiding this comment.
I think we should remove this example. I don't think it's something we want to encourage.
There was a problem hiding this comment.
we have a use case of icon-only badge here:
https://vivid.deno.dev/components/menu-item/#meta
TaylorJ76
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.