chore(docs): split-button docs update (VIV-2106) #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 377 +254
Lines 1562 9453 +7891
Branches 108 1529 +1421
===========================================
+ Hits 1562 9453 +7891
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rachelbt
requested changes
Feb 2, 2025
| ### Label | ||
|
|
||
| The `label` attribute adds the label text for the default action. | ||
|
|
There was a problem hiding this comment.
its a bit strange that the code sample is only after the secondary action label. It make sense but also seems like we forgot to add the code :)
| ``` | ||
|
|
||
| ## Connotation | ||
|
|
There was a problem hiding this comment.
its better to wrap the buttons with flex container and gap - in small screens the buttons are tight at each other:
same for appearance, size, and disabled
Co-authored-by: Rachel Bratt Tannenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.