-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workspace): use release-please #954
Conversation
Thanks for a thorough description. it's entirely clear what to review.
|
extracted the lint-pr-title action replacement to #956 |
Great! We might want to fine-tune it if we want to replicate the exact checks we have today (e.g., kebab-case?).
Perfect. I'll take care of the two remaining TODOs and we're good to go! |
Codecov Report
@@ Coverage Diff @@
## main #954 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 123 213 +90
Lines 1562 2364 +802
Branches 108 132 +24
==========================================
+ Hits 1562 2364 +802
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
closes #952 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
responsible pull request 🤝
(forget #952 this PR also takes care of removing beachball.)
READ ME PLEASE
This PR aims at changing the current Vivid release process (i.e., creating releases and corresponding npm packages) handled with beachball.
It does so by using the release-please action.
Every time PR is pushed on main, this action will be triggered. It will collect all the commits made on main related to
/libs/components
and update its own release PR (or create it if there is none) with this list and the next version number.The next version number is determined by the format of commit titles. They must follow the conventional commits rules.
To actually create the release, this release PR must be merged. It will then create the GitHub release, publish the npm package and deploy to Deno.
TODO
_deploy-deno.yml
for readability/maintenance purposes but technically, the Deno deployment could be done in the same step as the npm publication, reusing the same setup.FIRST "NEW" RELEASE
We'll need to update
bootstrap-sha
(currently set to an arbitrary value) before the first release. It will determine the commit from whichrelease-please
will start to scan for stuff to include in the release.After the first new release, we'll have to remove
release-as
. It is currently set to3.0.0
to avoid starting at1.0.0
.