feat(select): ghost select #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelbt
added
the
Work in Progress
|
🚀 Latest successful build of the PR deployed here. 🚀 |
rachelbt
removed
the
Work in Progress
YonatanKra
reviewed
Nov 25, 2021
| @@ -48,6 +48,9 @@ export class VWCSelect extends MWCSelect { | |||
| @property({ type: String, reflect: true }) | |||
| name: string | undefined; | |||
|
|
|||
| @property({ type: Boolean, reflect: true, attribute: 'ghost' }) | |||
There was a problem hiding this comment.
This needs to be tested.
Also, need to test the logic that's bound to it:
If ghost is true, dense must be true (at least that's what I see in the code).
There was a problem hiding this comment.
should we enforce programmatically? it's that mutating user's definition discussion again...
There was a problem hiding this comment.
We need because of the design. As I wrote in the summery of this PR its a quick & dirty fix. This component is different from our conventions in a lot of ways...
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and dirty adding a ghost layout.
Unable to use our layout because there's already a Layout function in MVC.
Ghost select only goes with dense. As Joella asked.