-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): unneeded top padding #1144
Conversation
🚀 Latest successful build of the PR deployed here. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setting label programmatically doesn't reflect on the attribute. which then causes a miss interpreted behavior;
by setting document.querySelector('vwc-select').label = ''
will not change the label attribute
use mdc-select--no-label
class which is set on shadowed container
I saw that solution in textarea. Anyway using the class is way better! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems stable now. wanna add to UI tests as well?
I've added ui-tests in this branch: |
No description provided.