Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: connotations are not applied correctly across the browsers and there are no tests covering that #458

Closed
gullerya opened this issue Nov 22, 2020 · 0 comments · Fixed by #459
Closed

fix: connotations are not applied correctly across the browsers and there are no tests covering that #458

gullerya opened this issue Nov 22, 2020 · 0 comments · Fixed by #459
Assignees
@gullerya @yinonov
Labels
enhancement New feature or request Type: Bug 🐞 Something isn't working

Comments

@gullerya
Copy link
Contributor

Right now there are few areas where connotations are NOT applied visually correctly:

  • badge primary on Firefox
  • button outlined on Firefox / Safari
  • button filled on Firefox (except the default primary)

This PR is first and foremost adds a test to cover all those.
@gullerya gullerya changed the title connotations are not applied correctly across the browsers and there are no tests covering that fix: connotations are not applied correctly across the browsers and there are no tests covering that Nov 22, 2020
@gullerya gullerya added Type: Bug 🐞 Something isn't working enhancement New feature or request labels Nov 22, 2020
gullerya added a commit that referenced this issue Nov 22, 2020
@gullerya
issue #458: added tests for all of the components using connotations
16e6e4c
@gullerya gullerya mentioned this issue Nov 22, 2020
Merged
gullerya added a commit that referenced this issue Nov 22, 2020
@gullerya
issue #458: improving the tests texting for clarity
33cfe9f
gullerya added a commit that referenced this issue Nov 22, 2020
@gullerya
issue #458: fixing the button selector for connotation part
a06fa60
gullerya added a commit that referenced this issue Nov 22, 2020
@gullerya
issue #458: few more things solved
4080895
gullerya added a commit that referenced this issue Nov 22, 2020
@gullerya
issue #458: few more things solved
7123fd1
gullerya added a commit that referenced this issue Nov 22, 2020
@gullerya
issue #458: all connotation issues fixed + tested
cee0f15
gullerya added a commit that referenced this issue Nov 22, 2020
@gullerya
issue #458: cleaning up the obsolete content
50ad463
gullerya added a commit that referenced this issue Nov 23, 2020
@gullerya @yinonov
fix: issue #458: added tests for all of the components using connotat…
d589f53 
…ions (#459)

* issue #458: added tests for all of the components using connotations

* issue #458: improving the tests texting for clarity

* issue #458: fixing the button selector for connotation part

* issue #458: few more things solved

* issue #458: few more things solved

* issue #458: all connotation issues fixed + tested

* issue #458: cleaning up the obsolete content

* switch aligned with connotation convention

Co-authored-by: yinonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gullerya gullerya

@yinonov yinonov

Labels
enhancement New feature or request Type: Bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: issue #458: added tests for all of the components using connotations Vonage/vivid
3 participants
@gullerya @lagjamhero @yinonov