-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vwc-helper-message): commonalize text helper component #575
Conversation
🚀 Latest successful build of the PR deployed here. 🚀 |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 64374cf |
…ub.com/Vonage/vivid into tech-commonalize-text-helper-component
I'm skipping review of yaml files |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@@ -36,7 +36,7 @@ jobs: | |||
path: | | |||
${{ steps.yarn-cache-dir-path.outputs.dir }} | |||
**/node_modules | |||
key: vivid-cache-yarn-${{ hashFiles('**/yarn.lock') }} | |||
key: vivid-cache-yarn-${{ hashFiles('**/package.json') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this likely to change in the future? can it be an environment variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think so - this is just about to clean our cache each time anything related to node_modules changes
protected render(): TemplateResult { | ||
return html` | ||
<vwc-icon class="helper-icon" type="info-negative" size="small"></vwc-icon> | ||
<span class="helper-text"><slot></slot></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideas for a11y, aria, wai-aria?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NP, I'll think about and we'll do some improvements round (opening a ticket for that)
textarea, textfield, select and file-picker - are all using the same logic to show a helper message which can turn to be an error message with error icon on demand.
This component make them all using the same thing, reduces amount of duplicate code, dependencies on some internal stuff of MWC and also available as a stand-alone functionality for the consumer applications.