fix: issue #558 fixing the spacer and some of the spacing glitches #574
Conversation
|
🚀 Latest successful build of the PR deployed here. 🚀 |
|
SonarCloud Quality Gate failed.
|
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2c1ec4e |
| } | ||
| } | ||
|
|
||
| .mdc-select { | ||
| & + .mdc-select-helper-line { | ||
| --mdc-theme-error: var(--mdc-select-ink-color); | ||
| min-height: 16px; |
There was a problem hiding this comment.
Like you've done here let's also set the vwc-textfield helper-line to min-height: 16px.
We could also use min-block-size if preferred
There was a problem hiding this comment.
Great, min-block-size is even better and thanks for the feedback!
I'll fix it here, but even more than this - can you please look onto the next PR (that one externalized the whole helper line, so if we'll go with it - the present one becomes obsolete).
| .spacer { | ||
| flex-basis: 14px; | ||
| .mdc-select-helper-text::before { | ||
| display: inline; |
There was a problem hiding this comment.
| display: inline; | |
| display: none; // originally inline-block breaks layout with 3px extra white space |
We no longer rely on this ::before element for helper-line height, so may be safer to remove?
|
fixed by #575 , no need to keep this |
closes #558
Also, BTW way of touching this area I've came across few inconsistencies in the helper line - all are aligned in this PR.