Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vwc-helper-message): check for appropriate a11i / aria labeling #578

Closed
gullerya opened this issue Jan 15, 2021 · 0 comments · Fixed by #586
Closed

feat(vwc-helper-message): check for appropriate a11i / aria labeling #578

gullerya opened this issue Jan 15, 2021 · 0 comments · Fixed by #586
Assignees
@gullerya
Labels
enhancement New feature or request

Comments

@gullerya
Copy link
Contributor

We've delivered vwc-helper-message component, but not supplied it with any aria labeling - we need to check if anything from a11i is applicable to it.
@gullerya gullerya added the enhancement New feature or request label Jan 15, 2021
@gullerya gullerya self-assigned this Jan 15, 2021
gullerya added a commit that referenced this issue Jan 18, 2021
@gullerya
issue #578: adding a11y marks and relevant ID
15ac83a
gullerya added a commit that referenced this issue Jan 18, 2021
@gullerya
issue #578: fixing the tests
6202da0
@gullerya gullerya mentioned this issue Jan 18, 2021
Merged
gullerya added a commit that referenced this issue Jan 18, 2021
@gullerya
issue #578: refactoring approach
59b2495
gullerya added a commit that referenced this issue Jan 19, 2021
@gullerya
feat(vwc-helper-message): iss 578 a11y for helper (#586)
5b49f3c 
* issue #578: adding a11y marks and relevant ID

* issue #578: fixing the tests

* issue #578: refactoring approach

* fixing some Storybook inconsistency

* fixing typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gullerya gullerya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(vwc-helper-message): iss 578 a11y for helper Vonage/vivid
1 participant
@gullerya