Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): preserve dense flavor even if there is no label attribute #627

Closed
gullerya opened this issue Feb 2, 2021 · 0 comments · Fixed by #628
Closed

fix(select): preserve dense flavor even if there is no label attribute #627

gullerya opened this issue Feb 2, 2021 · 0 comments · Fixed by #628
Assignees
@gullerya
Labels
Type: Bug 🐞 Something isn't working

Comments

@gullerya
Copy link
Contributor

gullerya commented Feb 2, 2021

Currently, if label attribute is removed, the select component behaves like it is not dense anymore. This is in general wrong, especially given the fact that the label may still be present and set via the JS property.

Fix: make the dense appearance stable regardless of the label state.
@gullerya gullerya added the Type: Bug 🐞 Something isn't working label Feb 2, 2021
@gullerya gullerya self-assigned this Feb 2, 2021
gullerya added a commit that referenced this issue Feb 2, 2021
@gullerya
issue #627: fixing select dense no label and some a11y issues
e13a8e2
gullerya added a commit that referenced this issue Feb 2, 2021
@gullerya
issue #627: fortifying dense and added test cases for pill + dense
19ec385
@gullerya gullerya mentioned this issue Feb 2, 2021
Merged
gullerya added a commit that referenced this issue Feb 3, 2021
@gullerya
fix(select): issue #627 select dense label (#628)
b421b6c 
* issue #627: fixing select dense no label and some a11y issues

* issue #627: fortifying dense and added test cases for pill + dense
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gullerya gullerya

Labels
Type: Bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): issue #627 select dense label Vonage/vivid
1 participant
@gullerya