Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIV-510 complex menu surface component #859

Closed
gullerya opened this issue May 24, 2021 · 0 comments · Fixed by #863
Closed

VIV-510 complex menu surface component #859

gullerya opened this issue May 24, 2021 · 0 comments · Fixed by #863
Assignees
@gullerya
Labels
enhancement New feature or request

Comments

@gullerya
Copy link
Contributor

vwc-menu component as of now bears only a capability to host vwc-list-items, while anything else pushed into it requires some amount of work to disable things etc.

We'd like to have another, more generic, component, which would behave like menu from the surfacing perspective, but allow custom content in it.

More detail can be seen in this Jira issue.
@gullerya gullerya added the enhancement New feature or request label May 24, 2021
@gullerya gullerya self-assigned this May 24, 2021
gullerya added a commit that referenced this issue May 26, 2021
@gullerya
issue #859 initial commit
9960eb3
gullerya added a commit that referenced this issue May 26, 2021
@gullerya
issue #859: initial content
4ec9f57
@gullerya gullerya mentioned this issue May 26, 2021
Merged
gullerya added a commit that referenced this issue May 31, 2021
@gullerya
issue #859: refactored surface to use our own wrapper
0074c32
gullerya added a commit that referenced this issue May 31, 2021
@gullerya
issue #859: fixing the tests
4fa625e
gullerya added a commit that referenced this issue May 31, 2021
@gullerya
issue #859: added complex drop down
e95b14a
gullerya added a commit that referenced this issue May 31, 2021
@gullerya
issue #859: added complex drop down
c9bdca4
gullerya added a commit that referenced this issue May 31, 2021
@gullerya
issue #859: replaces mwc-list with vwc-list in menu
82dd6c3
gullerya added a commit that referenced this issue May 31, 2021
@gullerya
issue #859: additional cleanups
8e49813
gullerya added a commit that referenced this issue Jun 1, 2021
@gullerya
issue #859: fixed as per CR remarks
29faa24
gullerya added a commit that referenced this issue Jun 1, 2021
@gullerya
issue #859: fixing CR remarks
c26ee81
gullerya added a commit that referenced this issue Jun 1, 2021
@gullerya
issue #859: fixing the dark theme
13fbddb
gullerya added a commit that referenced this issue Jun 1, 2021
@gullerya
issue #859: removing unneeded variables
02b0fc1
gullerya added a commit that referenced this issue Jun 1, 2021
@gullerya
issue #859: removing unneeded variables
ebec32f
gullerya added a commit that referenced this issue Jun 1, 2021
@gullerya
issue #859: removing unneeded variables
8cb11c2
gullerya added a commit that referenced this issue Jun 2, 2021
@gullerya
issue #859: fixing CR remarks
7d8f153
gullerya added a commit that referenced this issue Jun 3, 2021
@gullerya
issue #859: refactored surface styles
914bc7e
gullerya added a commit that referenced this issue Jun 3, 2021
@gullerya
issue #859: refactored surface styles
d93c6a7
gullerya added a commit that referenced this issue Jun 3, 2021
@gullerya @yinonov
feat(vwc-surface): viv-510 iss-859 complex menu surface (#863)
1520570 
* issue #859 initial commit

* issue #859: initial content

* fixing depcheck

* wip

* wip

* issue #859: refactored surface to use our own wrapper

* issue #859: fixing the tests

* issue #859: added complex drop down

* issue #859: added complex drop down

* fixing dependencies

* fixing Sonar issues

* issue #859: replaces mwc-list with vwc-list in menu

* issue #859: additional cleanups

* fix tests

* fixing CR remarks

* fixing CR remarks

* issue #859: fixed as per CR remarks

* issue #859: fixing CR remarks

* issue #859: fixing the dark theme

* issue #859: removing unneeded variables

* issue #859: removing unneeded variables

* issue #859: removing unneeded variables

* fixed a story: added dense and opening the dropdown on the start

* adding chevron icon to the dropper

* refine story

* issue #859: fixing CR remarks

* issue #859: refactored surface styles

* issue #859: refactored surface styles

Co-authored-by: yinon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gullerya gullerya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(vwc-surface): viv-510 iss-859 complex menu surface Vonage/vivid
1 participant
@gullerya