fix(side-drawer): refactor side drawer #1022
Conversation
|
|
🚀 Latest successful build of the PR deployed here. 🚀 |
| */ | ||
| onKeydown({ key }: KeyboardEvent): void { | ||
| console.log(this.type, this.open, key); | ||
| #onKeydown = ({ key }: KeyboardEvent): void => { |
There was a problem hiding this comment.
Should consider changing the name to #handleKeydown
| * Handles the `transitionend` event when the side drawer finishes opening/closing. | ||
| */ | ||
| onTransitionEnd(): void { | ||
| #onTransitionEnd = (): void => { |
There was a problem hiding this comment.
Should consider changing the name to #handleTransitionEnd
Clickable non-interactive elements must have at least 1 keyboard event listener lit-a11y/click-events-have-key-events
|
Kudos, SonarCloud Quality Gate passed!
|
Follow the commit path :)