Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): textarea scroll now working #1030

Merged
merged 3 commits into from
Aug 24, 2021
Merged

fix(textarea): textarea scroll now working #1030

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3506a78
Textarea ui test
YonatanKra Aug 23, 2021
341c63b
Apply the fix
YonatanKra Aug 23, 2021
16ad5d0
Merge branch 'master' into VIV-688/fix/textarea-scroll-issue
YonatanKra Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/textarea/src/vwc-textarea.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
display: inline-flex;
flex-direction: column;
outline: none;
.mdc-text-field__input {
pointer-events: all;
}
}

:host([dense][label]:not([label=''])) {
Expand Down
Binary file added ui-tests/snapshots/vwc-textarea.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 19 additions & 0 deletions ui-tests/tests/vwc-textarea/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import '@vonage/vwc-textarea';
import { storiesToElement } from '../../utils/storiesToElement';
import * as stories from '@vonage/vwc-textarea/stories/textarea.stories';

export async function createElementVariations(wrapper) {
const textElementWrapper = storiesToElement(stories);

wrapper.appendChild(textElementWrapper);

await new Promise(res => setTimeout(() => {
[...textElementWrapper.querySelectorAll('vwc-textfield')].forEach((child) => {
child.reportValidity();
child.firstElementChild.blur();
});
res();
}, 0));
}