Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vwc-data-grid): set determined styles #1070

Merged
merged 12 commits into from
Oct 4, 2021
Merged

fix(vwc-data-grid): set determined styles #1070

merged 12 commits into from
Oct 4, 2021
+216 −127

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Sep 24, 2021 •
edited
Loading

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@yinonov yinonov requested a review from jshenkman September 24, 2021 07:19
@yinonov
Copy link
Contributor Author

yinonov commented Sep 24, 2021

@jshenkman please review, the previous default vaadin style tokens are now stripped off. make sure grid match Vonage style

@Vonage Vonage deleted a comment from changeset-bot bot Sep 24, 2021
@yinonov
Copy link
Contributor Author

yinonov commented Sep 24, 2021

Closes #992

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 01f4a29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yinonov yinonov self-assigned this Sep 26, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 7339dcf into master Oct 4, 2021
@yinonov yinonov deleted the grid-refactor-style branch October 4, 2021 13:23
@yinonov yinonov mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YonatanKra YonatanKra YonatanKra approved these changes

@jshenkman jshenkman Awaiting requested review from jshenkman

Assignees

@yinonov yinonov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yinonov @YonatanKra @tveinfeld