feat(vwc-badge): viv-200 badge volta parity #485
Conversation
|
PR showcase deployed here. |
|
note #488 may reduce code difference |
|
@JoelGraham93 can u please break this PR from the badge combined? we aren't planning to support it atm. |
lagjamhero
changed the title
|
@yinon I've replaced |
None we are aware of yet |
| if (changes.has('dense')) { | ||
| if (this.dense && this.enlarged) { | ||
| this.enlarged = false; | ||
| } | ||
| } | ||
|
|
||
| if (changes.has('enlarged')) { | ||
| if (this.enlarged && this.dense) { | ||
| this.removeAttribute('dense'); | ||
| this.dense = false; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this can now become a decorator, on class or this updated method. let's discuss it
There was a problem hiding this comment.
example added in f5a7cfc
| @@ -29,14 +31,49 @@ | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
can all layout based styles be extracted to a foundation mixin?
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
PR showcase deployed here. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
PR showcase deployed here. |
No description provided.