Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make datepicker compatible with dialog #680

Merged
merged 25 commits into from
Mar 11, 2021
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6f3487e
make datepicker compatible with dialog
lagjamhero Feb 24, 2021
e2a2b0d
add positionElement support
lagjamhero Feb 25, 2021
0345895
depcheck
lagjamhero Feb 25, 2021
c16f129
lint
lagjamhero Feb 25, 2021
3343df9
increase waitInterval
lagjamhero Feb 25, 2021
cb34272
increase waitInterval
lagjamhero Feb 25, 2021
9284888
Merge branch 'master' into dialog-datepicker
yinonov Feb 28, 2021
8ef590b
Merge branch 'master' into dialog-datepicker
lagjamhero Mar 1, 2021
7570d0d
add fixed position support
lagjamhero Mar 1, 2021
660d92d
Merge branch 'master' into dialog-datepicker
lagjamhero Mar 2, 2021
3abe700
add fixed arg control
lagjamhero Mar 2, 2021
c1841c9
free up onReady and onChange apis
lagjamhero Mar 3, 2021
e5d30dc
Merge branch 'master' into dialog-datepicker
lagjamhero Mar 3, 2021
e456eaf
remove flaky waitInterval from tests
lagjamhero Mar 3, 2021
949b9ee
initial vwc-menu integration
lagjamhero Mar 8, 2021
66dc805
Merge branch 'master' into dialog-datepicker
lagjamhero Mar 8, 2021
f0ebe8f
update tests
lagjamhero Mar 9, 2021
f37d3ac
add wait after datepicker onReady
lagjamhero Mar 9, 2021
140e06c
Merge branch 'master' into dialog-datepicker
lagjamhero Mar 9, 2021
bdc08ba
add wait after onOpen test
lagjamhero Mar 9, 2021
1257ab1
remove redundant selector
lagjamhero Mar 9, 2021
b8e9f80
update depcheck ignores
lagjamhero Mar 10, 2021
d79e8e5
Merge branch 'master' into dialog-datepicker
yinonov Mar 10, 2021
eb4fa9d
forward flatpickr
yinonov Mar 10, 2021
1aa38bc
fix dep-check
lagjamhero Mar 11, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add wait after onOpen test
lagjamhero committed Mar 9, 2021
commit bdc08baab91764baa5d16ccdbf5bbd5789c343f4
1 change: 1 addition & 0 deletions components/datepicker/test/datepicker.test.js
Original file line number Diff line number Diff line change
@@ -101,6 +101,7 @@ describe('datepicker', () => {
const input = actualElement.querySelector('.vivid-input-internal.flatpickr-input');
input.click();
await actualElement.onOpen;
await waitNextTask();

datepicker = vwcMenu.querySelector('.vvd-datepicker.open');
assertComputedStyle(datepicker, { display: 'block' });