Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conversations): Correct conversations output and add tests #46

Merged
merged 6 commits into from
Jan 27, 2022
Merged

fix(conversations): Correct conversations output and add tests #46

merged 6 commits into from
Jan 27, 2022

Conversation

kellyjandrews
Copy link

This pull requests add tests and fixes to the packages/conversations module.

@kellyjandrews kellyjandrews added bug Something isn't working enhancement New feature or request labels Jan 25, 2022
@kellyjandrews kellyjandrews self-assigned this Jan 25, 2022
@kellyjandrews kellyjandrews mentioned this pull request Jan 26, 2022
Merged
abdulajet
abdulajet approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@abdulajet abdulajet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kellyjandrews kellyjandrews merged commit 570d92b into main Jan 27, 2022
@kellyjandrews kellyjandrews deleted the fix/conversation-outputs branch January 27, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulajet abdulajet abdulajet approved these changes

@conshus conshus Awaiting requested review from conshus

@SecondeJK SecondeJK Awaiting requested review from SecondeJK

@matt-lethargic matt-lethargic Awaiting requested review from matt-lethargic

Assignees

@kellyjandrews kellyjandrews

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellyjandrews @abdulajet