Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sms): Add SMS plugin #49

Merged
merged 5 commits into from
Feb 22, 2022
Merged

feat(sms): Add SMS plugin #49

merged 5 commits into from
Feb 22, 2022

Conversation

kellyjandrews
Copy link

This PR adds the plugin for sending SMS with the CLI.

In order to test, have a working local copy of the cli, and use bin/run plugins:link ./packages/sms and run tests with npx lerna run test --scope=@vonage/cli-plugin-sms`

@kellyjandrews kellyjandrews self-assigned this Feb 3, 2022
@kellyjandrews kellyjandrews added the enhancement New feature or request label Feb 3, 2022
matt-lethargic
matt-lethargic previously approved these changes Feb 4, 2022
packages/sms/src/commands/sms/index.ts Outdated Show resolved Hide resolved
packages/sms/package.json Outdated Show resolved Hide resolved
pardel
pardel approved these changes Feb 10, 2022
Copy link
Collaborator

@pardel pardel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, would like to request some changes

packages/sms/README.md Outdated Show resolved Hide resolved
packages/sms/oclif.manifest.json Outdated Show resolved Hide resolved
packages/sms/src/commands/sms/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@abdulajet abdulajet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kellyjandrews
Copy link
Author

@pardel Can you also approve - I'd like to get these changes published. Thanks!

@kellyjandrews kellyjandrews merged commit 67947f9 into main Feb 22, 2022
@kellyjandrews kellyjandrews deleted the feat/sms-send branch February 22, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants