refactor: use BiMap in FraudCheckRequestBuilder

Vonage · Nov 30, 2023 · 747bfb9 · 747bfb9
1 parent 5e3945c
commit 747bfb9
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/Vonage/NumberInsightV2/FraudCheck/FraudCheckRequestBuilder.cs b/Vonage/NumberInsightV2/FraudCheck/FraudCheckRequestBuilder.cs
@@ -14,7 +14,7 @@ internal class FraudCheckRequestBuilder : IBuilderForPhone, IBuilderForOptional
 
     /// <inheritdoc />
     public Result<FraudCheckRequest> Create() =>
-        this.phone.Match(this.ToSuccess, ToFailure)
+        this.phone.BiMap(this.ToRequest, ToParsingFailure)
             .Map(InputEvaluation<FraudCheckRequest>.Evaluate)
             .Bind(evaluation => evaluation.WithRules(VerifyInsights));
 
@@ -39,15 +39,13 @@ public IBuilderForOptional WithSimSwap()
         return this;
     }
 
-    private static Result<FraudCheckRequest> ToFailure(IResultFailure failure) =>
-        Result<FraudCheckRequest>.FromFailure(
-            ParsingFailure.FromFailures(ResultFailure.FromErrorMessage(failure.GetFailureMessage())));
+    private static IResultFailure ToParsingFailure(IResultFailure failure) =>
+        ParsingFailure.FromFailures(ResultFailure.FromErrorMessage(failure.GetFailureMessage()));
 
-    private Result<FraudCheckRequest> ToSuccess(PhoneNumber number) =>
-        Result<FraudCheckRequest>.FromSuccess(new FraudCheckRequest
-        {
-            Phone = number, Insights = this.insights,
-        });
+    private FraudCheckRequest ToRequest(PhoneNumber number) => new()
+    {
+        Phone = number, Insights = this.insights,
+    };
 
     private static Result<FraudCheckRequest> VerifyInsights(FraudCheckRequest request) =>
         InputValidation.VerifyNotEmpty(request, request.Insights, nameof(request.Insights));