Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing default serialization of zero's in loop #190

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

slorello89
Copy link
Contributor

allowing loop for talk and stream and making the serializer ignore if null and include if zero

Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #190 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   30.19%   30.17%   -0.02%     
==========================================
  Files          84       84              
  Lines        3786     3788       +2     
  Branches      384      384              
==========================================
  Hits         1143     1143              
  Misses       2557     2557              
- Partials       86       88       +2
Impacted Files Coverage Δ
Nexmo.Api/Request/VersionedApiRequest.cs 67.14% <100%> (+0.47%) ⬆️
Nexmo.Api/Request/ApiRequest.cs 51.37% <0%> (-0.4%) ⬇️
Nexmo.Api/LibLog/LibLog.cs 9.03% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c5019...be8c4fd. Read the comment docs.

@slorello89 slorello89 merged commit a51d9ec into master Feb 11, 2020
@slorello89 slorello89 deleted the bugfix/loop_param_ignored_when_zero branch February 25, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants