Add ability to search SMS #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheap
force-pushed
the
search-sms
branch
2 times, most recently
from
9ecbba3 to
5f1d621
Compare
Resolves #139
AlexLakatos
suggested changes
Nov 30, 2017
src/Message.js
Outdated
|
|
||
| search(id, callback) { | ||
| this.options.httpClient.request( | ||
| this.getRequestConfig("GET", "/search/message", { id: id }), |
There was a problem hiding this comment.
there is something on the beta branch that does GET with query Nexmo@dc02fb8#diff-1fdf421c05c1140f6d71444ea2b27638R609
There are two new HttpClient instances available: * this.options.api (api.nexmo.com) * this.options.rest (rest.nexmo.com) If you specify `host` in `options` when running `new Nexmo()` you can override the URL used
AlexLakatos
approved these changes
Dec 2, 2017
|
LGTM 🛩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #139