Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added new DTMF endpoints #977

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat: added new DTMF endpoints #977

merged 1 commit into from
Jan 8, 2025

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Jan 6, 2025

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck requested review from SMadani and Tr00d January 6, 2025 21:54
@manchuck manchuck mentioned this pull request Jan 6, 2025
Closed
SMadani
SMadani reviewed Jan 7, 2025
View reviewed changes
packages/voice/lib/voice.ts Outdated Show resolved Hide resolved
SMadani
SMadani requested changes Jan 7, 2025
View reviewed changes
Copy link

@SMadani SMadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gotta fix those typos and documentation for the "unsubscribe" endpoint.

@manchuck manchuck force-pushed the feat-voice-dtmf-updates branch from 5746837 to 72f9472 Compare January 7, 2025 13:59
@manchuck manchuck requested a review from SMadani January 7, 2025 14:03
@manchuck manchuck force-pushed the feat-voice-dtmf-updates branch from 72f9472 to b3987da Compare January 7, 2025 14:04
@manchuck manchuck marked this pull request as ready for review January 7, 2025 14:04
@manchuck manchuck force-pushed the feat-voice-dtmf-updates branch from b3987da to 01d62af Compare January 7, 2025 15:32
SMadani
SMadani reviewed Jan 7, 2025
View reviewed changes
packages/voice/lib/voice.ts Outdated Show resolved Hide resolved
SMadani
SMadani reviewed Jan 7, 2025
View reviewed changes
packages/voice/lib/voice.ts Outdated Show resolved Hide resolved
@manchuck manchuck force-pushed the feat-voice-dtmf-updates branch from 01d62af to 2d65e70 Compare January 8, 2025 14:42
@manchuck manchuck merged commit 40cfa57 into 3.x Jan 8, 2025
11 checks passed
@manchuck manchuck deleted the feat-voice-dtmf-updates branch January 8, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMadani SMadani SMadani approved these changes

@Tr00d Tr00d Awaiting requested review from Tr00d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manchuck @SMadani