Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dart-sass for improved compatibility #27

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Use dart-sass for improved compatibility #27

merged 1 commit into from
Nov 23, 2023

Conversation

PeeterPaal
Copy link
Contributor

@PeeterPaal PeeterPaal commented Nov 21, 2023 •
edited
Loading

Use dart-sass for improved compatibility when building CSS files from SCSS files.

As a result, project is also now Node 18+ compatible.

Testing:
Remove previous node_modules folder if present, run yarn install and then run grunt. Make sure all tasks complete without errors.

@PeeterPaal PeeterPaal added the enhancement New feature or request label Nov 21, 2023
@PeeterPaal PeeterPaal requested a review from tanelj November 21, 2023 08:54
@PeeterPaal PeeterPaal self-assigned this Nov 21, 2023
tanelj
tanelj approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@tanelj tanelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@tanelj tanelj merged commit 7902cd5 into master Nov 23, 2023
@tanelj tanelj deleted the sass-compatibility branch November 23, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanelj tanelj tanelj approved these changes

Assignees

@PeeterPaal PeeterPaal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeeterPaal @tanelj