Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed useElectronNet from got #20

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Removed useElectronNet from got #20

merged 1 commit into from
Sep 19, 2019

Conversation

lukechu10
Copy link
Contributor

Fixed issue with electron 6.0.9 causing a lot of errors:

events.js:303 Uncaught TypeError: this.on is not a function
    at once (events.js:303)
    at CallbacksRegistry.apply (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\callbacks-registry.js:41)
    at D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:281
    at EventEmitter.<anonymous> (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:271)
    at EventEmitter.emit (events.js:200)
    at Object.onMessage (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\init.js:42)
once @ events.js:303
apply @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\callbacks-registry.js:41
(anonymous) @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:281
(anonymous) @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:271
emit @ events.js:200
onMessage @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\init.js:42
events.js:303 Uncaught TypeError: this.on is not a function
    at once (events.js:303)
    at CallbacksRegistry.apply (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\callbacks-registry.js:41)
    at D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:281
    at EventEmitter.<anonymous> (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:271)
    at EventEmitter.emit (events.js:200)
    at Object.onMessage (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\init.js:42)
once @ events.js:303
apply @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\callbacks-registry.js:41
(anonymous) @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:281
(anonymous) @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:271
emit @ events.js:200
onMessage @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\init.js:42
_stream_writable.js:278 Uncaught TypeError: Cannot read property 'objectMode' of undefined
    at Writable.write (_stream_writable.js:278)
    at CallbacksRegistry.apply (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\callbacks-registry.js:41)
    at D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:281
    at EventEmitter.<anonymous> (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:271)
    at EventEmitter.emit (events.js:200)
    at Object.onMessage (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\init.js:42)
Writable.write @ _stream_writable.js:278
apply @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\callbacks-registry.js:41
(anonymous) @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:281
(anonymous) @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:271
emit @ events.js:200
onMessage @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\init.js:42
_stream_writable.js:585 Uncaught TypeError: Cannot read property 'corked' of undefined
    at Writable.end (_stream_writable.js:585)
    at CallbacksRegistry.apply (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\callbacks-registry.js:41)
    at D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:281
    at EventEmitter.<anonymous> (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:271)
    at EventEmitter.emit (events.js:200)
    at Object.onMessage (D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\init.js:42)
Writable.end @ _stream_writable.js:585
apply @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\callbacks-registry.js:41
(anonymous) @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:281
(anonymous) @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:271
emit @ events.js:200
onMessage @ D:\Users\lukew\Visual Studio\Minecraft-Box-Launcher\node_modules\electron\dist\resources\electron.asar\renderer\init.js:42

@lukechu10
Removed useElectronNet from got
11fd2c8 
Fixed issue with electron 6.0.9
@ci010 ci010 self-requested a review September 19, 2019 05:28
@ci010 ci010 added the bug label Sep 19, 2019
@ci010
Copy link
Collaborator

ci010 commented Sep 19, 2019

Merge this PR to unblock your case, and I'll investigate how this actually work....

@ci010 ci010 merged commit 57699ea into Voxelum:master Sep 19, 2019
@lukechu10
Copy link
Contributor Author

See issue: sindresorhus/got#443

ci010 pushed a commit that referenced this pull request Apr 4, 2020
@lukechu10 @ci010
fix: removed useElectronNet from got (#20)
8f0beb4 
Fixed issue with electron 6.0.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ci010 ci010 ci010 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukechu10 @ci010