-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfs backend #24
base: main
Are you sure you want to change the base?
zfs backend #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Take as much time as you need to test before merging (I know that sounds obvious).
I have ran into significant problems trying to get zfs to work in Docker on my system. This is due to the fact that Docker containers shares the host system kernel, which on my system is version 5.15.139, but in the Debian repos (our base Docker image is Debian) have a version of zfs for a 6.X kernel. Due to the fact that yaesm heavily relies on kernel based programs (btrfs, zfs, etc) it may make more sense to switch out test suite over to using virtual-machines instead of containers. This would allow us to avoid kernel incompatibilities as the virtual-machines would be running the correct kernel for the OS, unlike Docker containers. I am looking into using vagrant which is a tool for creating reproducible virtual-machines. Note that by using virtual-machines instead of Docker, we could also do testing on operating systems other than Linux (such as BSD, Windows, etc). |
c79fff1
to
8770a7a
Compare
rebased onto main after merging #25 |
8770a7a
to
48f2d14
Compare
rebased onto main after merging #29. |
48f2d14
to
3468184
Compare
rebased onto main after merging #31 |
I added functionality for taking both local and remote zfs snapshots. I also added some pytest fixtures that will be useful for testing zfs code moving forward. I have run into some issues however. Most importantly is I am realizing that the semantics of zfs do not fit into the current model/infrastructure of yaesm in the way that btrfs (and rsync) do. For example, the concept of a backup having a
It is obvious in this command that
zfs snapshots operate on datasets, which are not denoted by filesystem paths. Really in the context of zfs, |
No description provided.