Completed and fixed the reg elem visualization #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JStephenHuang
changed the title
|
When testing the traffic light element viz, dont forget to change the topic name to "/carla/traffic_lights/detection3d_array" in the hd_map_service "traffic_light" subscriber. |
VishGit1234
approved these changes
Jan 8, 2025
JStephenHuang
added a commit
that referenced
this pull request
Jan 21, 2025
* Fixed traffic visualization * fix: viz reg elem using custom class * member declarations should match member initialization list * undo notebook changes --------- Co-authored-by: JStephenHuang <[email protected]> Co-authored-by: Vishal Jayakumar <[email protected]> Co-authored-by: VishGit1234 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the reg elem visualization by using the custom reg elem classes and made mock function to get TrafficLightState enum.