-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source_id registration of GFDL-AM4, GFDL-ESM4, GFDL-CM4 and GFDL-ESM2M #318
Comments
@aradhakrishnanGFDL thanks for this, peek at CMIP6_source_id.html and let me know if any further tweaks are required |
Some changes are needed as we review the CV once again :( Sorry about that. But, the next few comments will provide the edits. |
"GFDL-ESM4":{ |
CM4 had CMIP removed while viewing the official CV. So, I am adding that here again plus few more edits: "GFDL-CM4":{ |
"GFDL-ESM2M":{ |
@aradhakrishnanGFDL thanks, in the
|
@aradhakrishnanGFDL from the global attributes of the
And have updated the entries noted above with this additional detail appropriately. From memory this model also included All the changes noted above (and via email) are included in the new pull request which can be viewed directly here |
@aradhakrishnanGFDL @ceblanton these changes are now in place. Take a peek at CMIP6_source_id.html or for more granular info WCRP-CMIP/CMIP6_CVs/CMIP6_source_id.json and we can make the final tweaks by reopening this issue and indicating what remains to be changed |
@durack1 The top level in ESM2M is at approximately 3 hPa. "description":"GFDL-AM2 (Cubed-sphere, C48L24, 2.5 deg lon x 2 deg lat; 144x90 longitude/latitude; 24 levels; model top 3 hpa)", |
Not sure if the ordering of components needs to be as-is in the global attributes WIP CV reference. But, we are updating our source in netCDF to this: GFDL-CM4 (2017): atmos: GFDL-AM4.1 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360 x 180 longitude/latitude; 33 levels; top level 1 hPa); ocean: GFDL-MOM6 (tripolar - nominal 0.25 deg; 1440 x 720 longitude/latitude; 75 levels; top grid cell 0-2 m); seaIce: SIS2 ; land: GFDL-LM4.0; aerosol: interactive; atmosChem: unnamed (fast chemistry, aerosol only); ocnBgchem: GFDL BLING v2; landIce: GFDL-LM4.0 |
Further changes requested, reopening |
@aradhakrishnanGFDL take a peek at CMIP6_source_id.html and let me know if any other tweaks are required |
@aradhakrishnanGFDL we noted a formatting inconsistency with the For reference, this issue was caught and resolved in #466 |
Requesting updates for GFDL-AM4, CM4 and ESM4 to release_year (2018).
|
@aradhakrishnanGFDL is the only change to update the |
@durack1 Yes, change to release_year only. Others remain unchanged. |
@aradhakrishnanGFDL that change is now implemented, please take a peek at CMIP6_source_id.html and let me know if any further tweaks are required |
Hi @durack1 (I have been requested to make two minor edits to GFDL-ESM2M. I will add another comment with those changes after verifications with other GFDL scientists. Sorry for the inconvenience)
|
|
@aradhakrishnanGFDL please drop the additional edit in this issue, and I'll process both |
@aradhakrishnanGFDL any chance those |
@durack1 Sorry, not yet. I will get back to you shortly. |
@aradhakrishnanGFDL no problem, I just wanted to make sure I wasn't holding anything up! |
CV changes. Here is my fork for reference. https://rawgit.com/aradhakrishnanGFDL/CMIP6_CVs/aradhakrishnanGFDL-patch-1/src/CMIP6_source_id.html "GFDL-CM4":{ |
Here is some info on what changes were specifically made to this version of the CV pertaining to the GFDL models. |
@aradhakrishnanGFDL thanks for the update, are the changes in your forks master branch? It doesn't seem to show up from my comparison aradhakrishnanGFDL/CMIP6_CVs@master...WCRP-CMIP:master |
not master, it's aradhakrishnanGFDL-patch-1 |
@aradhakrishnanGFDL are you sure? The only changes that I see are those changes that I made in #601. If you peruse aradhakrishnanGFDL/CMIP6_CVs@aradhakrishnanGFDL-patch-1...WCRP-CMIP:master#diff-489143e4bba3ae87c83073d3c9b593c8 you should see what I mean - only BCC updates |
@aradhakrishnanGFDL great, got those changes which are now in #602. I'll await an update after @jgjgfdl has taken one last run through |
Thank you. We are ready now! |
@aradhakrishnanGFDL @jgjgfdl thanks for these tweaks, the changes should now in place. Please take a look at CMIP6_source_id.html and let me know if any further tweaks are required |
Thanks Paul and Aparna.
Jasmin
…On Fri, Sep 14, 2018 at 8:32 PM, Paul J. Durack ***@***.***> wrote:
@aradhakrishnanGFDL <https://github.com/aradhakrishnanGFDL> @jgjgfdl
<https://github.com/jgjgfdl> thanks for these tweaks, the changes should
now in place. Please take a look at CMIP6_source_id.html
<https://rawgit.com/WCRP-CMIP/CMIP6_CVs/master/src/CMIP6_source_id.html>
and let me know if any further tweaks are required
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#318 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKqYKIvZZrmgJdRmDmGPeomFAfbKRgFFks5ubEq2gaJpZM4NVqAF>
.
--
Jasmin John
NOAA/GFDL
201 Forrestal Road
Princeton, NJ 08540
609-452-5323
|
Thank you, Paul! Looks good to me. As soon as https://github.com/PCMDI/cmip6-cmor-tables/blob/master/Tables/CMIP6_CV.json is updated, we can run more QC tests at GFDL for publishing . Thanks, |
@doutriaux1 @mauzey1 can you guys kick off an update to CMIP6_CV.json please? Is the cronjob re-enabled? |
Hi @durack1 @doutriaux1 I see the most recent version of the CMIP6_CV.json in the CMOR repo now, which is great. Thank you. |
The text was updated successfully, but these errors were encountered: