Skip to content

Commit

Permalink
run pre-commit
Browse files Browse the repository at this point in the history
  • Loading branch information
larsbuntemeyer committed Oct 16, 2024
1 parent 904f660 commit c010d5d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Note that there might be some issues if your are using the [cmor library](https:
* The [archive specifications](https://zenodo.org/records/10961069) recommed to use `crs` as the name of the grid mapping variable. However, using cmor, it doensn't seem to be possible to properly adapt the grid mapping's variable name (https://github.com/WCRP-CORDEX/archive-specifications/issues/17).
* In your input dataset json file, make sure the `_cmip6_option` is removed so that more flexible CV's are possible. See also [this discussion](https://github.com/PCMDI/cmor/discussions/679#discussioncomment-3842958). You can also check the [example input file](https://github.com/WCRP-CORDEX/cordex-cmip6-cmor-tables/blob/main/Tables/CORDEX-CMIP6_remo_example.json).
* Make sure to use `cmor>=3.8.0` since `CORDEX-CMIP6` does not require the `further_info_url`, see also https://github.com/PCMDI/cmor/pull/727. Otherwise, a default `further_info_url` will be added by cmor that is created from related attributes but will probably point to an invalid URL.
* UPDATE: resolved since [3.9.0](https://github.com/PCMDI/cmor/releases/tag/3.9.0) ~~With the current cmor release (`3.8.0`), a [default realm attribute](https://github.com/PCMDI/cmor/issues/736) is written, although not required by the CV. This is fixed in an upcoming cmor release.~~
* UPDATE: resolved since [3.9.0](https://github.com/PCMDI/cmor/releases/tag/3.9.0) ~~With the current cmor release (`3.8.0`), a [default realm attribute](https://github.com/PCMDI/cmor/issues/736) is written, although not required by the CV. This is fixed in an upcoming cmor release.~~
* Finally, if you use these tables together with the cmor library and successfully create cmorized files, it is still not guaranteed that you used the CV correctly. This is unfortunately but reasonably due to the close relation between cmor and the original CMIP6 requirements for AR6. This means, e.g., that CV entries other than the basic `insitution_id` or `source_id` are not as rigorously checked but mainly only for their presence if they are part of the required global attributes. For example, only attributes in the CV that are defined as lists are checked for consistency but not if they are defined as subsections. For some more details on this issue, please follow https://github.com/PCMDI/cmor/discussions/679#discussioncomment-3889102.

## Feedback
Expand Down

0 comments on commit c010d5d

Please sign in to comment.