Increase MOST test tolerance #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jtgrasb If it comes up again, we can try saving the input files created by |
akeeste
approved these changes
Dec 1, 2023
jtgrasb
added a commit
that referenced
this pull request
Dec 1, 2023
* Adding load mitigating controls and OWC (#39) * Adding load mitigating controls * adding OWC applications case example * adding 2020b version * adding hydroData source * update readmes, linting * adding OWC orifice data * add h5 file, mod gitignore, add testOWC * add LMC and OWC tests to CI * add LMC and OWC tests * remove R2020b simulink file, remove last LTI block * remove extra library file * fix some paths, toolboxes required by the tests * fix issue from merging dev, remove paraview tests * add OWC MCR case to tests --------- Co-authored-by: akeeste <[email protected]> * Common input files (#50) * common RM3 hydroData and geometry * common OSWEC hydroData and geometry files * multiple wave headings * update input files * consolidate sphere hydrodata * update input files * revert nonlinear hydro files back to original * fix tests * remove outdated comments from input files * Increase test tolerance (#51) * Increase test tolerance * Change to relative tolerances * Increase relative tolerance for tower * Update README.md (#52) Co-authored-by: Kelley Ruehl <[email protected]> --------- Co-authored-by: dforbush2 <[email protected]> Co-authored-by: akeeste <[email protected]> Co-authored-by: Adam Keester <[email protected]> Co-authored-by: Kelley Ruehl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the tolerance of MOST tests to a relative tolerance and increasing the tolerance for the tower loads. The MOST tests seem to be failing due to numerical inconsistencies in the optimization result. This should fix the issue with the tests failing.
The difference occurs on the runner but not locally. It could be a difference between Linux and Windows OS but not sure how to test this.