Updating the visualization examples to Paraview 5.9.1 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmichelenstrofer or @akeeste can one of you verify that the updated state files are working? Thank you! |
|
@kmruehl Yes I am able to load the new *.pvsm state files for both the OSWEC and the RM3 |
|
@akeeste thank you! |
cmichelenstrofer
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
It works, can be merged. Some suggestion for future improvements:
- Add segment tensions to the one of the RM3 views (maybe make the lines thicker too)
- Remove the specific path "C:/kmruehl/..." from the .pvsm files. "files from state path" will not work either way but at least we are not pushing paths specific to one computer
- Ideally we would create multiple views without creating multiple copies of the objects (right now there are 3 grounds, 3 waves ,etc.)
|
@cmichelenstrofer thank you! Yes, I agree those are great suggestions. I'll open an issue with those suggestions. Looks like I merged the PR right before your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the visualization examples to Paraview 5.9.1. This PR does the following:
*.pvsmstate files for both WEC-Sim_Application cases with Paraview 5.9.1This PR relates to WEC-Sim/WEC-Sim#595 and WEC-Sim/WEC-Sim#459