fix(djs): more cache fixes

WFCD · May 1, 2020 · 3ed3023 · 3ed3023
1 parent 4659415
commit 3ed3023
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/commands/Roles/AddRole.js b/src/commands/Roles/AddRole.js
@@ -11,11 +11,11 @@ const JoinableRole = require('../../models/JoinableRole.js');
  */
 function getRoleForString(string, message) {
   const trimmedString = string.trim();
-  const roleFromId = message.guild.roles.get(trimmedString);
+  const roleFromId = message.guild.roles.cache.get(trimmedString);
   let roleFromName;
   if (typeof roleFromId === 'undefined') {
-    roleFromName = message.guild.roles
-      .find(item => item.name.toLowerCase() === trimmedString.toLowerCase());
+    roleFromName = message.guild.roles.cache
+      .find(role => role.name.toLowerCase() === trimmedString.toLowerCase());
   }
   return roleFromId || roleFromName || null;
 }

diff --git a/src/eventHandlers/AssignDefaultRoles.js b/src/eventHandlers/AssignDefaultRoles.js
@@ -26,7 +26,7 @@ class AssignDefaultRolesHandle extends Handler {
     this.logger.debug(`Running ${this.id} for ${this.event}`);
 
     const defaultRoles = JSON.parse(await this.settings.getGuildSetting(member.guild, 'defaultRoles') || '[]')
-      .map(roleId => member.guild.roles.get(roleId)).filter(role => role);
+      .map(roleId => member.guild.roles.cache.get(roleId)).filter(role => role);
     if (defaultRoles.length) {
       await member.roles.add(defaultRoles, `Default role assignment for ${member.user.tag}`);
     }