Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hpa enabled for testing #17

Open
wants to merge 15 commits into
base: dev-charts
Choose a base branch
from
Open

fix: hpa enabled for testing #17

wants to merge 15 commits into from

Conversation

palla714
Copy link

This PR is to merge the tested hpa config in the process of refactoring the badgr-server and simplifying the helm chart . The subbranch dev-charts-hpa is used for testing both hpa config and managed DB config

image
image

Build Job URL
https://jenkins-labs-ci-cd.apps.dev.lxp.academy.who.int/job/badgr-server/job/dev-charts-hpa/5/

Build URL
http://dev-charts-hpa-badgr-server-badgr-labs-dev.apps.dev.lxp.academy.who.int/

@krishnamadhavan
Copy link

@palla714 I had asked you to make changes to the Jenkinsfile, right ? I cannot see them in the changes.

@palla714
Copy link
Author

@palla714 I had asked you to make changes to the Jenkinsfile, right ? I cannot see them in the changes.

Hi.. I changed the Jenkinsfile in the dev-charts and then pulled them in my new branch.. After testing the run I noticed that I added the changes to dev-charts branch itself, but as it was working so did not discard it.

@krishnamadhavan
Copy link

@palla714 I had asked you to make changes to the Jenkinsfile, right ? I cannot see them in the changes.

Hi.. I changed the Jenkinsfile in the dev-charts and then pulled them in my new branch.. After testing the run I noticed that I added the changes to dev-charts branch itself, but as it was working so did not discard it.

If you check the difference between your Jenkinsfile from dev-charts branch and the one below, I see there's a lot of items missing. Can you check and update them ?

https://github.com/WHOAcademy/learning-delivery-api/blob/main/Jenkinsfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants