Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update encoding of CHANGELOG #56

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Update encoding of CHANGELOG #56

merged 1 commit into from
Nov 28, 2024

Conversation

pjaap
Copy link
Member

@pjaap pjaap commented Nov 28, 2024

On my end, VSCode always mutates the CHANGELOG.md. Even without changing anything in that file.

I investigated this:

before:

$ file CHANGELOG.md 
CHANGELOG.md: ASCII text, with CRLF, LF line terminators

after opening with VSCode (without doing anything)

$ file CHANGELOG.md 
CHANGELOG.md: ASCII text

Somehow it removes CRLF, LF line terminators ... The file was probably edited with another operating system/strange editor.

Is there any reason to keep this? Otherwise this PR makes it plain ASCII. Then, my VSCode is happy :)
No contents are changed, btw.

@j-fu
Copy link
Member

j-fu commented Nov 28, 2024

It was initially generated with git-cliff in order to catch up with older commits. I don't intend to use this tool further.

Changing to normal ASCII is ok.

@pjaap pjaap merged commit d677e85 into main Nov 28, 2024
9 checks passed
@pjaap pjaap deleted the fix/CHANGELOG branch November 28, 2024 12:42
@pjaap
Copy link
Member Author

pjaap commented Nov 28, 2024

Ok, thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants